feat: Add buffering to provisioner job logs #4918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve overall build performance, and especially under load. It removes the old `id` column on the `provisioner_job_logs` table and replaces it with an auto-incrementing big integer to preserve order. Funny enough, we never had to care about order before because inserts would at minimum be 1ms different. Now they aren't, so the order needs to be preserved.
coadler
approved these changes
Nov 7, 2022
| r.flushLogsTimer.Reset(r.logBufferInterval) | ||
| return | ||
| } | ||
| if len(r.queuedLogs) > 100 { |
There was a problem hiding this comment.
I think this 100 should be configurable like the buffer interval.
There was a problem hiding this comment.
I added a comment and left it reconfigurable for now.
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE provisioner_job_logs DROP COLUMN id; | |||
|
|
|||
| ALTER TABLE provisioner_job_logs ADD COLUMN id BIGSERIAL PRIMARY KEY; | |||
There was a problem hiding this comment.
Can we guarantee that adding this bigserial column will keep the same order of logs?
There was a problem hiding this comment.
It likely won't in all cases, but it seems to in most.
Having a safe migration seems unreasonable here, so we settle for pretty great.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve overall build performance, and especially under load.
It removes the old
idcolumn on theprovisioner_job_logstable and replaces it with an auto-incrementing big integer to preserve order.Funny enough, we never had to care about order before because inserts would at minimum be 1ms different. Now they aren't, so the order needs to be preserved.