Support high build time variation in progress bar #4941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Nov 8, 2022
| @@ -26,6 +26,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestLoadTest(t *testing.T) { | |||
| t.Skipf("This test is flakey. See https://github.com/coder/coder/issues/4942") | |||
There was a problem hiding this comment.
I already disabled the flakey test in another PR.
Comment on lines
52
to
54
| // If variation is too high (and greater than second), don't show | ||
| // progress bar and give range. | ||
| const highVariation = stddev / median > 0.1 && highGuess - lowGuess > 1 |
There was a problem hiding this comment.
I might do this logic on the backend instead and return simpler API values. In the current format, it's not possible for our CLI to display a progress bar or estimated time remaining without duplicating this logic.
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
|
@kylecarbs — agree it would've been better to add this into the backend, but I want to merge into the frontend for now since it's not the most important work I could be doing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4676
This PR changes the Progress Bar's behavior so that it shows an estimate range (and no progress slider) when estimate variation is too high.