Skip to content

Support high build time variation in progress bar #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 17, 2022
Merged

Support high build time variation in progress bar #4941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4605fd0
Don't show progress bar when data inconclusive
ammario Oct 25, 2022
50ff192
Merge remote-tracking branch 'origin/main' into pb-improvements
ammario Nov 7, 2022
0e0bff6
Make tests pass
ammario Nov 7, 2022
dd32287
Build out frontend
ammario Nov 8, 2022
ecd5168
fixup! Build out frontend
ammario Nov 8, 2022
63e790e
fixup! Build out frontend
ammario Nov 8, 2022
4c8378e
fixup! Build out frontend
ammario Nov 8, 2022
3c5219c
Merge remote-tracking branch 'origin/main' into pb-improvements
ammario Nov 16, 2022
6f914a4
Refactor to use percentiles
ammario Nov 17, 2022
08b2814
Merge remote-tracking branch 'origin/main' into pb-improvements
ammario Nov 17, 2022
3c0bc88
Update frontend
ammario Nov 17, 2022
0c596f3
site: make tests pass
ammario Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make tests pass
  • Loading branch information
@ammario
ammario committed Nov 7, 2022
commit 0e0bff64f425488fe2e5e153ab832fcaee929176
1 change: 1 addition & 0 deletions cli/loadtest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
)

func TestLoadTest(t *testing.T) {
t.Skipf("This test is flakey. See https://github.com/coder/coder/issues/4942")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already disabled the flakey test in another PR.

t.Parallel()

t.Run("PlaceboFromStdin", func(t *testing.T) {
Expand Down
1 change: 0 additions & 1 deletion coderd/metricscache/buildtime.go
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions coderd/templates_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ func TestTemplateMetrics(t *testing.T) {
})
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
require.Equal(t, -1, template.ActiveUserCount)
require.Empty(t, template.BuildTimeStats)
require.Empty(t, template.BuildTimeStats[codersdk.WorkspaceTransitionStart])

coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
workspace := coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID)
Expand Down Expand Up @@ -665,7 +665,7 @@ func TestTemplateMetrics(t *testing.T) {
require.Eventuallyf(t, func() bool {
template, err = client.Template(ctx, template.ID)
require.NoError(t, err)
startMs := template.BuildTimeStats.StartMillis
startMs := template.BuildTimeStats[codersdk.WorkspaceTransitionStart].Median
return startMs != nil && *startMs > 1
},
testutil.WaitShort, testutil.IntervalFast,
Expand Down