chore: Unify Docker terraform templates #4952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a34a91 to
b32fdb2
Compare
Changes to terraform templates: * Remove DNS (this can interfere with users running their own DNS servers) * Remove `lower()` restriction from hostnames so that it will show the name set by the user, as-is (there is no restriction on upper case letters in hostnames) * Remove superfluous `trap` in entrypoints, this is already handled by the init script * Switch from `command` to `entrypoint` as the latter can support more Docker images out-of-the-box
b32fdb2 to
4e79a9c
Compare
kylecarbs
approved these changes
Nov 8, 2022
ammario
approved these changes
Nov 8, 2022
| EOT | ||
| ] | ||
| env = ["CODER_AGENT_TOKEN=${coder_agent.main.token}"] | ||
| entrypoint = ["sh", "-c", replace(coder_agent.main.init_script, "/localhost|127\\.0\\.0\\.1/", "host.docker.internal")] |
There was a problem hiding this comment.
I think we can replace these with the new 'provider.url' attribute.
There was a problem hiding this comment.
@ammario we can't. I never merged the change to adjust the hostname.
The primary problem was if you were using the tunnel, because the access URL would be https://<url>:443. If we just adjusted the hostname, then host.docker.internal:443 would be dialed.
There was a problem hiding this comment.
Ah that would indeed have been neat. I guess we’ll keep it like this for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to terraform templates:
servers)
lower()restriction from hostnames so that it will show thename set by the user, as-is (there is no restriction on upper case
letters in hostnames)
trapin entrypoints, this is already handled bythe init script
commandtoentrypointas the latter can support moreDocker images out-of-the-box