fix: Use immutable names for volumes in example templates #4954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Nov 8, 2022
I like the labels! |
deansheather
approved these changes
Nov 8, 2022
| name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root" | ||
| name = "coder-${data.coder_workspace.me.id}-home" | ||
| lifecycle { | ||
| ignore_changes = all |
There was a problem hiding this comment.
should put a comment about what this means
There was a problem hiding this comment.
I considered it, but this section begins with a link that explains it in greater detail.
If you think it’s good even considering this I don’t mind adding it (my thinking was that keeping the doc more focused/short here was better).
There was a problem hiding this comment.
I don't mind, I didn't see the link 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes towards #3000, #3386
Related #3409
Revives #3663 (with changes)
I've added a bunch of labels to the docker templates that are nice when needed, but look a bit verbose. Thoughts? Keep them all? Reduce their numbers? Or only keep them in one template?
These changes also mean that it should be safe for anyone to update their templates to the latest version as long as they keep the
lifecycleblocks (thanks @ammario for that tip).