Skip to content

chore: Find source files once in Makefile targets #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2022
Merged

chore: Find source files once in Makefile targets #4968

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6138ebc
chore: Find source files once in Makefile targets
mafredri Nov 9, 2022
ccdb21a
fix: Use find for shell files and improve perf via ignore dirs
mafredri Nov 9, 2022
201b4cc
fix: Even more exclusions
mafredri Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Use find for shell files and improve perf via ignore dirs
  • Loading branch information
@mafredri
mafredri committed Nov 9, 2022
commit ccdb21ac6aa281db84353e4501c5b22d23ffee9a
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ ZSTDFLAGS := -6
endif

# Source files used for make targets, evaluated on use.
GO_SRC_FILES = $(shell find . -not -path './vendor/*' -type f -name '*.go')
GO_SRC_FILES = $(shell find . -not \( -path './vendor/*' -o -path './.coderv2/*' -o -path '*/node_modules/*' \) -type f -name '*.go')
# All the shell files in the repo, excluding ignored files.
SHELL_SRC_FILES = $(shell shfmt -f . | grep -v "\.coderv2/")
SHELL_SRC_FILES = $(shell find . -not \( -path './vendor/*' -o -path './.coderv2/*' -o -path '*/node_modules/*' \) -type f -name '*.sh')

# All ${OS}_${ARCH} combos we build for. Windows binaries have the .exe suffix.
OS_ARCHES := \
Expand Down