Skip to content

fix: prevent races from processing build logs after channel close #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix: prevent races from processing build logs after channel close #4984

merged 1 commit into from
Nov 9, 2022

Conversation

deansheather
Copy link
Member

No description provided.

@deansheather deansheather requested a review from coadler November 9, 2022 17:54
@deansheather deansheather marked this pull request as ready for review November 9, 2022 17:54
mafredri
mafredri approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

I think we could refactor this to be a bit nicer in the case of overflow (i.e. no discard). We could simply keep track of created after and have a goroutine pushing data once there's room in the buffer. (Not for this PR.)

@deansheather deansheather merged commit 0ae8d5e into main Nov 9, 2022
@deansheather deansheather deleted the dean/guard-build-log-events branch November 9, 2022 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deansheather @mafredri @kylecarbs