Skip to content

feat: tracing improvements #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2022
Merged

feat: tracing improvements #4988

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1affbe
feat: move tracing middleware higher up the middleware stack
deansheather Nov 9, 2022
032f1cf
fixup! feat: move tracing middleware higher up the middleware stack
deansheather Nov 9, 2022
d892c21
fixup! feat: move tracing middleware higher up the middleware stack
deansheather Nov 17, 2022
7383e8c
fixup! feat: move tracing middleware higher up the middleware stack
deansheather Nov 17, 2022
343e27d
fixup! feat: move tracing middleware higher up the middleware stack
deansheather Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! feat: move tracing middleware higher up the middleware stack
  • Loading branch information
@deansheather
deansheather committed Nov 9, 2022
commit 032f1cf7ba7c29bd3bf48804ee0bfd7a18ab61a2
3 changes: 1 addition & 2 deletions coderd/tracing/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ func FuncNameSkip(skip int) string {
// context and replaced with a no-op span. This is useful for avoiding logs
// being added to span (to save money).
func RunWithoutSpan(ctx context.Context, fn func(ctx context.Context)) {
ctx, span := trace.NewNoopTracerProvider().Tracer("").Start(ctx, "")
defer span.End()
ctx = trace.ContextWithSpan(ctx, NoopSpan)
fn(ctx)
}