Skip to content

chore: default to generic troubleshooting link #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

chore: default to generic troubleshooting link #5007

merged 1 commit into from
Nov 17, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Nov 10, 2022

We are now displaying a troubleshooting URL if the agent fails to connect after a while! This PR makes the following changes to the initial behavior:

  • simplifies messaging
  • link to generic troubleshooting section (most templates do not have troubleshooting steps in README and we can change all of our examples to link back to the README)

@bpmct bpmct requested a review from a team as a code owner November 10, 2022 19:27
@bpmct bpmct requested review from BrunoQuaresma and removed request for a team November 10, 2022 19:27
@mafredri mafredri mentioned this pull request Nov 11, 2022
Merged
BrunoQuaresma
BrunoQuaresma approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in the mean time I'm good with this 👍

@bpmct bpmct force-pushed the bpmct/troubleshoot-link branch from c8ffb1b to 970a814 Compare November 17, 2022 11:05
@bpmct bpmct enabled auto-merge (squash) November 17, 2022 11:06
@bpmct bpmct merged commit 8e468c4 into main Nov 17, 2022
@bpmct bpmct deleted the bpmct/troubleshoot-link branch November 17, 2022 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri left review comments

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpmct @mafredri @BrunoQuaresma