Skip to content

fix: Revert develop.sh timeout -> curl change #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: Revert develop.sh timeout -> curl change #5008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Revert develop.sh timeout -> curl change 
It seems `--retry-all-errors` is not available on e.g. curl 7.68.0.
  • Loading branch information
@mafredri
mafredri committed Nov 10, 2022
commit a44d365a19d0eb8450115507edb15166fad468fd
2 changes: 1 addition & 1 deletion scripts/develop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fatal() {
start_cmd "${CODER_DEV_SHIM}" server --address 0.0.0.0:3000

echo '== Waiting for Coder to become ready'
curl --silent --fail --connect-timeout 1 --max-time 1 --retry 60 --retry-delay 1 --retry-max-time 60 --retry-all-errors 'http://localhost:3000/healthz' ||
timeout 60s bash -c 'until curl -s --fail http://localhost:3000/healthz > /dev/null 2>&1; do sleep 0.5; done' ||
fatal 'Coder did not become ready in time'

# Check if credentials are already set up to avoid setting up again.
Expand Down