fix: template permissions page never loads #5014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
commented
Nov 10, 2022
| @@ -152,65 +140,59 @@ export const TemplateLayout: FC<PropsWithChildren> = ({ children }) => { | |||
| } | |||
| > | |||
| <Stack direction="row" spacing={3} className={styles.pageTitle}> | |||
| {!isLoading && ( | |||
There was a problem hiding this comment.
I'm not sure why we were wrapping all these blocks in isLoading - seems like we just need to make sure the template is there (and we do on line 114).
Kira-Pilot
commented
Nov 10, 2022
| @@ -26,14 +25,11 @@ export const TemplatePermissionsPage: FC< | |||
| context: { templateId: template?.id }, | |||
| }) | |||
| const { templateACL, userToBeUpdated, groupToBeUpdated } = state.context | |||
| if (!template || !permissions) { | |||
| return <Loader /> | |||
| } | |||
There was a problem hiding this comment.
We shouldn't need another loader here, right? We already have the Suspense in the parent component with a fallback loader. Also, at this point, we can be certain template is loaded.
|
Thanks for those changes! I QA it and it is working as expected. |
BrunoQuaresma
approved these changes
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hopefully) resolves #4953
Previously, on the Template Permissions page, we always showed a loader if a user did not have permissions to update the template.
We don't anymore; we just disable the dropdowns on the page:
In addition, I made an effort to clean up loading on this page overall. @BrunoQuaresma could you please review carefully? I think you were the last person to touch this code.