Skip to content

fix: Set a default CODER_ACCESS_URL in Helm #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2022
Merged

fix: Set a default CODER_ACCESS_URL in Helm #5041

merged 2 commits into from
Nov 13, 2022

Conversation

kylecarbs
Copy link
Member

This allows for a simple helm apply to create a full Coder deployment that works for creating workspaces.

This allows for a simple `helm apply` to create a full Coder
deployment that works for creating workspaces.
@kylecarbs kylecarbs self-assigned this Nov 12, 2022
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be mentioned in values.yaml as one of the envs we set for you

@kylecarbs
Copy link
Member Author

Hmm, why? We don't have it present by default.

@kylecarbs kylecarbs requested a review from ammario November 13, 2022 20:10
@kylecarbs kylecarbs merged commit 2a6fff9 into main Nov 13, 2022
@kylecarbs kylecarbs deleted the defaulturl branch November 13, 2022 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants