fix: Improve tailnet connections by reducing timeouts #5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This awaits connection ping before running a dial. Before, we were hitting the TCP retransmission and handshake timeouts, which could intermittently add 1 or 5 seconds to a connection being initialized.
mafredri
reviewed
Nov 14, 2022
| defer ticker.Stop() | ||
| completedCtx, completed := context.WithCancel(ctx) | ||
| run := func() { | ||
| ctx, cancelFunc := context.WithTimeout(completedCtx, time.Second) |
There was a problem hiding this comment.
@kylecarbs Couldn't this timeout result in no ping ever completing if RTT is >1s?
Also wondering if there's a potential edge-case race in completedCtx being based on ctx. Let's say caller does cancel on their context, and ultimately in the select below completedCtx.Done() is selected to resolve before ctx.Done().
There was a problem hiding this comment.
@mafredri you are certainly correct. I won't have time to tackle this today, but I'd appreciate if you went through this code and cleaned up any races you might encounter. You have a much better eye for these problems than I!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This awaits connection ping before running a dial. Before, we were hitting the TCP retransmission and handshake timeouts, which could intermittently add 1 or 5 seconds to a connection being initialized.