Show template.display_name in the site UI #5069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Nov 14, 2022
coderd/templates.go
Outdated
| @@ -504,7 +503,7 @@ func (api *API) patchTemplateMeta(rw http.ResponseWriter, r *http.Request) { | |||
| DisplayName: displayName, | |||
| Description: desc, | |||
| Icon: icon, | |||
| DefaultTtl: int64(maxTTL), | |||
| DefaultTtl: int64(defaultTTLMillis), | |||
There was a problem hiding this comment.
Thought this had to be a bug but I was surprised to notice we're storing nanoseconds in the database... 😅
Kira-Pilot
reviewed
Nov 14, 2022
| import * as Yup from "yup" | ||
|
|
||
| export const Language = { | ||
| nameLabel: "Name", | ||
| displayNameLabel: "Display name", |
There was a problem hiding this comment.
We're actually moving away from these Language blocks and instead using react-i18next for translations because it's a cleaner solution. We try to knock them out whenever we come across them in legacy code. Would you mind adding a new translation for your label in templatePage.json? There's an example PR here that should walk you through how to do it. Let me know if you need any help!
There was a problem hiding this comment.
Thanks for the suggestion, @Kira-Pilot! 6396671 . I guess that I can polish the entire page, but would rather do this in a follow-up PR :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3321
This PR modifies the site code to present the
template.display_nameon pages: "Templates" and "Create workspace". I will modify the/api/v2/workspacesin the follow-up (to exposetemplate_display_name, and then cover "Workspaces" and "Workspace Summary".