feat: Let port-forwarding support custom http(s) port #5084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
249d4af to
4f8a9b9
Compare
|
Rebase atop of the latest main branch. |
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
9889b81 to
a8eeddf
Compare
deansheather
approved these changes
Dec 1, 2022
|
Thank you for your contribution, sorry we took so long to get this merged! |
ninehills
added a commit
to ninehills/coder
that referenced
this pull request
Dec 2, 2022
v0.13.1 * tag 'v0.13.1': (49 commits) fix: do not truncate system PATH in win installer (coder#5243) feat: add debouncing to provisionerd rpc calls (coder#5198) feat: Let port-forwarding support custom http(s) port (coder#5084) fix: Fix nil-pointer deref on `checkAuthorization` (coder#5236) chore: bump cron-parser from 4.6.0 to 4.7.0 in /site (coder#5221) chore: bump github.com/gohugoio/hugo from 0.105.0 to 0.107.0 (coder#5222) chore: bump google.golang.org/api from 0.100.0 to 0.103.0 (coder#5219) chore: bump github.com/spf13/viper from 1.13.0 to 1.14.0 (coder#5220) .github: remove "never stale" chore: bump google.golang.org/grpc from 1.50.1 to 1.51.0 (coder#5223) feat: Add support for update checks and notifications (coder#4810) chore: bump golang.org/x/crypto from 0.1.0 to 0.3.0 (coder#5224) chore: bump tj-actions/branch-names from 6.2 to 6.3 (coder#5217) chore: bump hmarr/auto-approve-action from 2 to 3 (coder#5216) chore: bump google-github-actions/auth from 0 to 1 (coder#5218) chore: bump golangci/golangci-lint-action from 3.3.0 to 3.3.1 (coder#5214) Refactored Quota Docs (coder#5195) feat: Define Prometheus port in the pod spec (coder#5213) fix: Generate trial in `scripts/develop.sh` (coder#5231) chore: Add missing metrics description (coder#5212) ...
ninehills
added a commit
to ninehills/coder
that referenced
this pull request
Dec 2, 2022
v0.13.1 * tag 'v0.13.1': (49 commits) fix: do not truncate system PATH in win installer (coder#5243) feat: add debouncing to provisionerd rpc calls (coder#5198) feat: Let port-forwarding support custom http(s) port (coder#5084) fix: Fix nil-pointer deref on `checkAuthorization` (coder#5236) chore: bump cron-parser from 4.6.0 to 4.7.0 in /site (coder#5221) chore: bump github.com/gohugoio/hugo from 0.105.0 to 0.107.0 (coder#5222) chore: bump google.golang.org/api from 0.100.0 to 0.103.0 (coder#5219) chore: bump github.com/spf13/viper from 1.13.0 to 1.14.0 (coder#5220) .github: remove "never stale" chore: bump google.golang.org/grpc from 1.50.1 to 1.51.0 (coder#5223) feat: Add support for update checks and notifications (coder#4810) chore: bump golang.org/x/crypto from 0.1.0 to 0.3.0 (coder#5224) chore: bump tj-actions/branch-names from 6.2 to 6.3 (coder#5217) chore: bump hmarr/auto-approve-action from 2 to 3 (coder#5216) chore: bump google-github-actions/auth from 0 to 1 (coder#5218) chore: bump golangci/golangci-lint-action from 3.3.0 to 3.3.1 (coder#5214) Refactored Quota Docs (coder#5195) feat: Define Prometheus port in the pod spec (coder#5213) fix: Generate trial in `scripts/develop.sh` (coder#5231) chore: Add missing metrics description (coder#5212) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
CODER_ACCESS_URL=https://coder.example.com:8443CODER_WILDCARD_ACCESS_URL=*.coder.example.comThen the port-forwarding url will be
https://3000--xxx--xxxx--xxx.coder.example.comIt should be:
https://3000--xxx--xxxx--xxx.coder.example.com:8443