Skip to content

feat: Allow hiding password auth, changing OpenID Connect text and OpenID Connect icon #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 31, 2023
Merged

feat: Allow hiding password auth, changing OpenID Connect text and OpenID Connect icon #5101

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3addcaf
Allow hiding password entry, changing OpenID Connect text and OpenID …
normana10 Nov 16, 2022
40bc156
Docs
normana10 Nov 16, 2022
0f4a40e
Cleaning
normana10 Nov 16, 2022
90d900c
Fix Prettier and Go test and TS compile error
normana10 Nov 16, 2022
97b5019
Fix LoginPage test
normana10 Nov 16, 2022
8019ec7
Prettier
normana10 Nov 16, 2022
97d9d46
Fix storybook
normana10 Nov 16, 2022
0858ad0
Add query param to un-hide password auth
normana10 Nov 24, 2022
f13df97
Merge branch 'main' into configurable-openid-connect-text
normana10 Dec 6, 2022
6afca64
Cleaning
normana10 Dec 6, 2022
410fc98
Merge branch 'main' into configurable-openid-connect-text
normana10 Dec 14, 2022
e9a91cb
Merge branch 'main' into configurable-openid-connect-text
normana10 Jan 16, 2023
fc12496
Hide password by default when OIDC enabled
normana10 Jan 17, 2023
9480f8e
Ran prettier, updated goldenfiles and ran "make gen"
normana10 Jan 17, 2023
475b2bf
Fixed and added LoginPage test
normana10 Jan 17, 2023
77b230c
Ran prettier
normana10 Jan 17, 2023
77f0fb2
PR Feedback and split up SignInForm.tsx
normana10 Jan 20, 2023
1ed7911
Updated golden files
normana10 Jan 20, 2023
e31a37e
Fix auto-genned-files
normana10 Jan 23, 2023
9207175
make gen -B
normana10 Jan 26, 2023
201d424
Revert provisioner files?
normana10 Jan 26, 2023
8333256
Merge branch 'main' into configurable-openid-connect-text
normana10 Jan 30, 2023
7ce525e
Fix lint error
normana10 Jan 30, 2023
3d5ec00
Merge branch 'main' into configurable-openid-connect-text
kylecarbs Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint error
  • Loading branch information
@normana10
normana10 committed Jan 30, 2023
commit 7ce525e41628467da6149ff4731d2e9a04d96af0
8 changes: 2 additions & 6 deletions site/src/pages/LoginPage/LoginPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,7 @@ describe("LoginPage", () => {
render(<LoginPage />)

// Then
expect(
await screen.queryByText(Language.passwordSignIn),
).not.toBeInTheDocument()
expect(screen.queryByText(Language.passwordSignIn)).not.toBeInTheDocument()
await screen.findByText(Language.githubSignIn)
})

Expand Down Expand Up @@ -142,9 +140,7 @@ describe("LoginPage", () => {
render(<LoginPage />)

// Then
expect(
await screen.queryByText(Language.passwordSignIn),
).not.toBeInTheDocument()
expect(screen.queryByText(Language.passwordSignIn)).not.toBeInTheDocument()
await screen.findByText(Language.githubSignIn)

const showPasswordAuthLink = screen.getByText("Show password login")
Expand Down