fix: Fix tab default #5104
Merged
fix: Fix tab default #5104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Nov 16, 2022
| set: (value: string) => void | ||
| } | ||
|
|
||
| export const useTab = (tabKey: string): UseTabResult => { | ||
| export const useTab = (tabKey: string, defaultValue: string): UseTabResult => { |
There was a problem hiding this comment.
Should we assign a default value here in case the consumer doesn't pass one in?
There was a problem hiding this comment.
We don't know what value it can be so I think we can left it required for now.
Kira-Pilot
approved these changes
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is a minor thing and does not block the user at all I didn't add more tests.