fix: Users page filter resets page #5124
Merged
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma I keep seeing this slight change to the logo at the bottom of the page in storybook changes, do you know what that's about? |
code-asher
approved these changes
Nov 17, 2022
|
@presleyp good question. I think it is because the image quality and the logo use gradients so the snapshot always gets a difference of 0.01% I guess. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the filter on a page should reset the page to page 1, but that wasn't happening on the Users page. The fix is to avoid going to the
gettingUsersstate in response to theUPDATE_FILTERevent, and instead to wait until theUPDATE_PAGEevent to fetch users.