Skip to content

refactor: Remove mono font from empty title #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022
Merged

refactor: Remove mono font from empty title #5125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 19 additions & 26 deletions site/src/components/EmptyState/EmptyState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import Box from "@material-ui/core/Box"
import { makeStyles } from "@material-ui/core/styles"
import Typography from "@material-ui/core/Typography"
import { FC, ReactNode } from "react"
import { MONOSPACE_FONT_FAMILY } from "../../theme/constants"
import { combineClasses } from "../../util/combineClasses"

export interface EmptyStateProps {
Expand Down Expand Up @@ -38,24 +37,19 @@ export const EmptyState: FC<React.PropsWithChildren<EmptyStateProps>> = (

return (
<Box className={combineClasses([styles.root, className])} {...boxProps}>
<div className={styles.header}>
<Typography variant="h5" className={styles.title}>
{message}
<Typography variant="h5" className={styles.title}>
{message}
</Typography>
{description && (
<Typography
variant="body2"
color="textSecondary"
className={combineClasses([styles.description, descriptionClassName])}
>
{description}
</Typography>
{description && (
<Typography
variant="body2"
color="textSecondary"
className={combineClasses([
styles.description,
descriptionClassName,
])}
>
{description}
</Typography>
)}
</div>
{cta}
)}
{cta && <div className={styles.cta}>{cta}</div>}
</Box>
)
}
Expand All @@ -70,18 +64,17 @@ const useStyles = makeStyles(
textAlign: "center",
minHeight: 300,
padding: theme.spacing(3),
fontFamily: MONOSPACE_FONT_FAMILY,
},
header: {
marginBottom: theme.spacing(3),
},

title: {
fontWeight: 600,
fontFamily: "inherit",
fontSize: theme.spacing(3),
},
description: {
marginTop: theme.spacing(1),
fontFamily: "inherit",
marginTop: theme.spacing(1.5),
fontSize: theme.spacing(2),
},
cta: {
marginTop: theme.spacing(4),
},
}),
{ name: "EmptyState" },
Expand Down