Skip to content

fix: don't use yamux for in-memory provisioner{,d} streams #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2022
Merged

fix: don't use yamux for in-memory provisioner{,d} streams #5136

merged 4 commits into from
Nov 22, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Nov 19, 2022

Green is before, yellow/blue is after
image
image

It still seems like DRPC is causing most of our allocs/s, but this fixes a significant chunk of the rest.

@coadler coadler requested a review from kylecarbs November 19, 2022 00:12
@coadler coadler self-assigned this Nov 19, 2022
@coadler coadler requested a review from deansheather November 22, 2022 17:43
@coadler coadler merged commit 1f20cab into main Nov 22, 2022
@coadler coadler deleted the colin/rm-memory-yamix branch November 22, 2022 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @deansheather