feat: Validate Git tokens before consuming them #5167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericpaulsen when you get a shot, we should make some docs that explain how to set Git authentication up for providers like BitBucket, GitHub Enterprise, and GitLab self-hosted. This will involve setting the following values: # GitHub Enterprise
CODER_GITAUTH_0_VALIDATE_URL=https://<hostname>/api/v3/user
CODER_GITAUTH_0_AUTH_URL=https://<hostname>/login/oauth/authorize
CODER_GITAUTH_0_TOKEN_URL=https://<hostname>/login/oauth/access_tokenWe should do this for the other providers and manually test that it works as well when adding docs. The validate URL is added in this PR and is required. |
This works the exact same way that the Git credential manager does. It ensures the user token is valid before returning it to the client. It's been manually tested on GitHub, GitLab, and BitBucket.
mafredri
reviewed
Nov 25, 2022
deansheather
approved these changes
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works the exact same way that the Git credential manager does. It ensures the user token is valid before returning it to the client.
It's been manually tested on GitHub, GitLab, and BitBucket.