fix: Improve debuggability of ptytest cleanup #5170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are sporadic flakes in some tests on Windows related to the use of `ptytest`. Since it's not clear why they fail, this commit adds some more logging and timeouts to the cleanup methods.
2a527c9 to
b202855
Compare
mtojek
approved these changes
Nov 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are sporadic flakes in some tests on Windows related to the use of
ptytest. Since it's not clear why they fail, this commit adds somemore logging and timeouts to the cleanup methods.
Example of failed test:
cli/cliui TestWorkspaceResources/SingleAgentSSHLink: https://github.com/coder/coder/actions/runs/3541232323/jobs/5945245470
The test largely looks successful but for some reason we don't exit the test. This could mean 1) the channel doesn't get closed because
cliui.WorkspaceResourcesdoesn't exit, or perhaps more likely, we're stuck waiting for cleanup to happen forptytest. Or maybe somewhere else.