refactor: Return template version name in the workspace build API #5178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
reviewed
Nov 28, 2022
| @@ -51,6 +51,7 @@ func (api *API) workspaceBuild(rw http.ResponseWriter, r *http.Request) { | |||
| data.metadata, | |||
| data.agents, | |||
| data.apps, | |||
| data.templateVersions[0], | |||
There was a problem hiding this comment.
This will panic if the length is not at least 1. That may be fine if we have the expectation that this is always true, but wanted to point it out.
There was a problem hiding this comment.
Yes, we always expect to have at least 1. Thanks for pointing it out.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI will use the template version name in some places so we need to have it returned from the API. I tried doing a JOIN but it looks like it does not update the
workspaceBuildmodel properly. We are running some queries to get extra "workspace build" data so I made it there but I'm not sure if it is the best approach.