Skip to content

Get previous template version #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 6, 2022
Merged

Get previous template version #5230

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5766918
Get previous template version
BrunoQuaresma Dec 1, 2022
e64b8c9
Sort fake database method
BrunoQuaresma Dec 1, 2022
0d411a0
Add route and test
BrunoQuaresma Dec 1, 2022
2403912
Fic test
BrunoQuaresma Dec 1, 2022
764a596
Scope previous version to the template id
BrunoQuaresma Dec 1, 2022
4300414
Fix authorize tests
BrunoQuaresma Dec 1, 2022
30c586c
Fix test
BrunoQuaresma Dec 1, 2022
17ed909
Fix test
BrunoQuaresma Dec 2, 2022
6c7c8b9
Fix tests
BrunoQuaresma Dec 2, 2022
b16b9b2
Update coderd/database/queries/templateversions.sql
BrunoQuaresma Dec 2, 2022
c80d66a
Fix fmt
BrunoQuaresma Dec 2, 2022
0f3c2b4
Update coderd/database/databasefake/databasefake.go
BrunoQuaresma Dec 5, 2022
d218d32
Update coderd/templateversions.go
BrunoQuaresma Dec 5, 2022
223f649
Merge branch 'main' of github.com:coder/coder into bq/previous-version
BrunoQuaresma Dec 5, 2022
23fda22
Wrap errors inside of err!= nil
BrunoQuaresma Dec 5, 2022
f7a84f2
Merge branch 'bq/previous-version' of github.com:coder/coder into bq/…
BrunoQuaresma Dec 5, 2022
2ada7c8
Fix fake database
BrunoQuaresma Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrap errors inside of err!= nil
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Dec 5, 2022
commit 23fda224c2094dd664d3322b2585203505322ee2
27 changes: 15 additions & 12 deletions coderd/templateversions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,13 +648,14 @@ func (api *API) previousTemplateVersionByOrganizationAndName(rw http.ResponseWri
OrganizationID: organization.ID,
Name: templateVersionName,
})
if errors.Is(err, sql.ErrNoRows) {
httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{
Message: fmt.Sprintf("No template version found by name %q.", templateVersionName),
})
return
}
if err != nil {
if errors.Is(err, sql.ErrNoRows) {
httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{
Message: fmt.Sprintf("No template version found by name %q.", templateVersionName),
})
return
}

httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
Message: "Internal error fetching template version.",
Detail: err.Error(),
Expand All @@ -667,13 +668,15 @@ func (api *API) previousTemplateVersionByOrganizationAndName(rw http.ResponseWri
Name: templateVersionName,
TemplateID: templateVersion.TemplateID,
})
if errors.Is(err, sql.ErrNoRows) {
httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{
Message: fmt.Sprintf("No previous template version found for %q.", templateVersionName),
})
return
}

if err != nil {
if errors.Is(err, sql.ErrNoRows) {
httpapi.Write(ctx, rw, http.StatusNotFound, codersdk.Response{
Message: fmt.Sprintf("No previous template version found for %q.", templateVersionName),
})
return
}

httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
Message: "Internal error fetching the previous template version.",
Detail: err.Error(),
Expand Down