Skip to content

Add build number to workspace_build audit logs #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 6, 2022
Merged

Add build number to workspace_build audit logs #5267

merged 15 commits into from
Dec 6, 2022

Conversation

Kira-Pilot
Copy link
Member

@Kira-Pilot Kira-Pilot commented Dec 2, 2022 •
edited
Loading

A couple of little cleanup items here:

  • resolves Add build number to audit logs #5234, a request from @ElliotG
    Screen Shot 2022-12-02 at 3 48 12 PM
  • We now hide audit log links for workspace_build entries that were created without the necessary additional field info (because we don't have enough information to form the link, so the links were dead). This is a fix that will affect legacy audit log entries only. All new audit log entries going forward should be created with the necessary link info.
  • We've adjusted the audit log documentation since we now audit workspace_builds in a more comprehensive way

@kylecarbs kylecarbs requested a review from coadler December 2, 2022 21:05
@Kira-Pilot Kira-Pilot requested review from a team and removed request for coadler December 2, 2022 22:10
coadler
coadler approved these changes Dec 5, 2022
View reviewed changes
coderd/audit.go Outdated
Comment on lines 198 to 200
if err != nil {
api.Logger.Error(ctx, "unmarshal additional fields", slog.Error(err))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this happens, should we try to populate additionalFields with something to show it failed, maybe like unknown.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner December 6, 2022 18:06
@Kira-Pilot Kira-Pilot requested review from jsjoeio and removed request for a team December 6, 2022 18:06
jsjoeio
jsjoeio approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Kira-Pilot Kira-Pilot merged commit df389d4 into main Dec 6, 2022
@Kira-Pilot Kira-Pilot deleted the add-build-number-to-audit/kira-pilot branch December 6, 2022 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add build number to audit logs
3 participants
@Kira-Pilot @jsjoeio @coadler