Skip to content

feat: add lazygit, remove kubic, use dotfiles in dogfood image #5271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 6, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 2, 2022

Changes

This adds lazygit to the dogfood image.

This also uses the coder dotfiles command in the startup_script.

@jsjoeio jsjoeio requested a review from f0ssel December 2, 2022 21:42
@jsjoeio jsjoeio self-assigned this Dec 2, 2022
@jsjoeio jsjoeio changed the title feat: update neovim, add lazygit to dogfood image feat: add lazygit, use dotfiles in dogfood image Dec 2, 2022
@jsjoeio jsjoeio marked this pull request as ready for review December 2, 2022 21:45
Copy link
Contributor

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure why dogfood is failing // going to rerun it // installing LG does indeed work.

coder@coder-sydney:~$ sudo bash
root@coder-sydney:/home/coder# LAZYGIT_VERSION=$(curl -s "https://api.github.com/repos/jesseduffield/lazygit/releases/latest" | grep '"tag_name":' |  sed -E 's/.*"v*([^"]+)".*/\1/') && \
>   curl -Lo lazygit.tar.gz "https://github.com/jesseduffield/lazygit/releases/latest/download/lazygit_${LAZYGIT_VERSION}_Linux_x86_64.tar.gz" && \
>   tar xf lazygit.tar.gz -C /usr/local/bin lazygit
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 5445k  100 5445k    0     0  3033k      0  0:00:01  0:00:01 --:--:--  107M
root@coder-sydney:/home/coder# echo $LAZYGIT_VERSION  
0.36.0

@ghuntley ghuntley force-pushed the jsjoeio/update-dogfood branch from ab841ce to 3ed2fa6 Compare December 5, 2022 06:17
@ghuntley
Copy link
Contributor

ghuntley commented Dec 5, 2022

Rebased off main and starting CI again.

@ghuntley
Copy link
Contributor

ghuntley commented Dec 5, 2022

Dogfood on main is broken

#0 1.916 Get:31 https://apt.postgresql.org/pub/repos/apt focal-pgdg/main amd64 Packages [417 kB]
#0 2.120 Get:32 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages [2350 kB]
#0 2.288 Get:33 http://security.ubuntu.com/ubuntu focal-security/universe amd64 Packages [972 kB]
#0 2.349 Get:34 https://ppa.launchpadcontent.net/ansible/ansible/ubuntu focal/main amd64 Packages [1086 B]
#0 2.937 Get:35 https://ppa.launchpadcontent.net/neovim-ppa/stable/ubuntu focal/main amd64 Packages [1943 B]
#0 5.207 Get:36 http://mirror.pit.teraswitch.com/ubuntu focal-updates/universe amd64 Packages [1273 kB]
#0 5.345 Get:37 http://mirror.pit.teraswitch.com/ubuntu focal-backports/main amd64 Packages [55.2 kB]
#0 5.347 Get:38 http://mirror.pit.teraswitch.com/ubuntu focal-backports/universe amd64 Packages [28.6 kB]
#0 5.505 Reading package lists...
#0 6.614 E: The repository 'https://plug-mirror.rcac.purdue.edu/opensuse/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_20.04  Release' does not have a Release file.

@jsjoeio jsjoeio force-pushed the jsjoeio/update-dogfood branch from 803e555 to f1330f2 Compare December 5, 2022 20:27
@jsjoeio jsjoeio force-pushed the jsjoeio/update-dogfood branch from b1b60cd to 33ec6e5 Compare December 5, 2022 20:38
@jsjoeio jsjoeio changed the title feat: add lazygit, use dotfiles in dogfood image feat: add lazygit, remove kubic, use dotfiles in dogfood image Dec 5, 2022
@jsjoeio jsjoeio requested a review from johnstcn December 5, 2022 20:39
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 5, 2022

Last commit is based off: https://github.com/coder/v1/pull/13438

@ghuntley ghuntley merged commit 9e4d213 into main Dec 6, 2022
@ghuntley ghuntley deleted the jsjoeio/update-dogfood branch December 6, 2022 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants