Skip to content

fix: avoid terraform state concurrent access, remove global mutex #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: avoid terraform state concurrent access, remove global mutex #5273

merged 1 commit into from
Dec 6, 2022

Conversation

deansheather
Copy link
Member

  • Use a separate cache dir for each provisioner daemon
  • Use a mutex for each provisioner when running terraform processes that may read or alter state (just in case)
  • Fix a test that was using a single provisioner in parallel (causing flakes)

@deansheather deansheather requested a review from coadler December 3, 2022 00:10
coadler
coadler approved these changes Dec 3, 2022
View reviewed changes
@deansheather deansheather enabled auto-merge (squash) December 3, 2022 01:48
@deansheather deansheather disabled auto-merge December 3, 2022 01:48
@deansheather deansheather enabled auto-merge (squash) December 3, 2022 01:48
@deansheather deansheather merged commit 6651c16 into main Dec 6, 2022
@deansheather deansheather deleted the dean/fix-terraform-corruption branch December 6, 2022 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @coadler