Skip to content

fix: Fix resource avatar when icon is empty string #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix: Fix resource avatar when icon is empty string #5291

merged 1 commit into from
Dec 5, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2022-12-05 at 13 24 18

After:
Screen Shot 2022-12-05 at 13 24 38

@BrunoQuaresma BrunoQuaresma self-assigned this Dec 5, 2022
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review December 5, 2022 16:27
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner December 5, 2022 16:27
@BrunoQuaresma BrunoQuaresma requested review from jsjoeio and removed request for a team December 5, 2022 16:27
jsjoeio
jsjoeio approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BrunoQuaresma BrunoQuaresma merged commit 02dcd0e into main Dec 5, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-resource-avatar branch December 5, 2022 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @jsjoeio