Skip to content

site: don't show progress bar for new templates #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2022
Merged

site: don't show progress bar for new templates #5298

merged 2 commits into from
Dec 7, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Dec 5, 2022

Resolves #5229

@ammario ammario requested a review from a team as a code owner December 5, 2022 23:35
@ammario ammario requested review from BrunoQuaresma and removed request for a team December 5, 2022 23:35
BrunoQuaresma
BrunoQuaresma approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) December 7, 2022 14:04
@BrunoQuaresma BrunoQuaresma merged commit ee605b3 into main Dec 7, 2022
@BrunoQuaresma BrunoQuaresma deleted the no-nan branch December 7, 2022 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a workspace from a new template shows NaN in build progress bar
2 participants
@ammario @BrunoQuaresma