-
Notifications
You must be signed in to change notification settings - Fork 889
feat(dogfood): install nix package manager #5308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share a bit more context about this change and fix the link in the description?
Apologies - I linked to the wrong link. See conversation at #devrandom. I use nix personally and not having access to the nix package manager is causing self-papercuts. Setting |
ca4652e
to
9402c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the comments! Feel free to merge if other approvers are 👍 .
4e3e64c
to
38eea8e
Compare
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Co-authored-by: Dean Sheather <dean@deansheather.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
pin it, just pin it
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
7b5e174
to
fb1eac8
Compare
a37bc93
to
ec10dc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looking pretty clean! 👍🏻
dogfood/main.tf
Outdated
echo '. /home/coder/.nix-profile/etc/profile.d/nix.sh' >> /home/coder/.bashrc | ||
bash /opt/nix/install --no-daemon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test this, but imagine it should be a bit more portable and avoid adding the entry every startup.
echo '. /home/coder/.nix-profile/etc/profile.d/nix.sh' >> /home/coder/.bashrc | |
bash /opt/nix/install --no-daemon | |
bash /opt/nix/install --no-daemon | |
if ! grep -q '. ~/.nix-profile/etc/profile.d/nix.sh' ~/.bashrc; then | |
echo '. ~/.nix-profile/etc/profile.d/nix.sh' >> ~/.bashrc | |
fi |
Ultimately, we might want to add this logic into /etc/profile.d/nix.sh
and /etc/zsh/zprofile
(via Dockerfile) so that it's available in all shells. But that can be done in a separate PR.
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Internal discussion thread.