Skip to content

feat: remove loadtest cmd, add new scaletest cmd #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add createworkspaces tests
  • Loading branch information
deansheather committed Dec 13, 2022
commit a6a36f740ade2424d5d7f11a33353be94065b84e
194 changes: 194 additions & 0 deletions scaletest/createworkspaces/config_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,194 @@
package createworkspaces_test

import (
"testing"
"time"

"github.com/google/uuid"
"github.com/stretchr/testify/require"

"github.com/coder/coder/coderd/httpapi"
"github.com/coder/coder/codersdk"
"github.com/coder/coder/scaletest/agentconn"
"github.com/coder/coder/scaletest/createworkspaces"
"github.com/coder/coder/scaletest/reconnectingpty"
"github.com/coder/coder/scaletest/workspacebuild"
)

func Test_UserConfig(t *testing.T) {
t.Parallel()

id := uuid.New()

cases := []struct {
name string
config createworkspaces.UserConfig
errContains string
}{
{
name: "OK",
config: createworkspaces.UserConfig{
OrganizationID: id,
Username: "test",
Email: "test@test.coder.com",
},
},
{
name: "NoOrganizationID",
config: createworkspaces.UserConfig{
OrganizationID: uuid.Nil,
Username: "test",
Email: "test@test.coder.com",
},
errContains: "organization_id must not be a nil UUID",
},
{
name: "NoUsername",
config: createworkspaces.UserConfig{
OrganizationID: id,
Username: "",
Email: "test@test.coder.com",
},
errContains: "username must be set",
},
{
name: "NoEmail",
config: createworkspaces.UserConfig{
OrganizationID: id,
Username: "test",
Email: "",
},
errContains: "email must be set",
},
}

for _, c := range cases {
c := c

t.Run(c.name, func(t *testing.T) {
t.Parallel()

err := c.config.Validate()
if c.errContains != "" {
require.Error(t, err)
require.Contains(t, err.Error(), c.errContains)
} else {
require.NoError(t, err)
}
})
}
}

func Test_Config(t *testing.T) {
t.Parallel()

id := uuid.New()

userConfig := createworkspaces.UserConfig{
OrganizationID: id,
Username: id.String(),
Email: id.String() + "@example.com",
}

workspaceConfig := workspacebuild.Config{
OrganizationID: id,
UserID: id.String(),
Request: codersdk.CreateWorkspaceRequest{
TemplateID: id,
},
}

reconnectingPTYConfig := reconnectingpty.Config{
AgentID: id,
}

agentConnConfig := agentconn.Config{
AgentID: id,
ConnectionMode: agentconn.ConnectionModeDirect,
HoldDuration: httpapi.Duration(time.Minute),
}

cases := []struct {
name string
config createworkspaces.Config
errContains string
}{
{
name: "OK",
config: createworkspaces.Config{
User: userConfig,
Workspace: workspaceConfig,
ReconnectingPTY: &reconnectingPTYConfig,
AgentConn: &agentConnConfig,
},
},
{
name: "OKOptional",
config: createworkspaces.Config{
User: userConfig,
Workspace: workspaceConfig,
ReconnectingPTY: nil,
AgentConn: nil,
},
},
{
name: "BadUserConfig",
config: createworkspaces.Config{
User: createworkspaces.UserConfig{
OrganizationID: uuid.Nil,
},
},
errContains: "validate user",
},
{
name: "BadWorkspaceConfig",
config: createworkspaces.Config{
User: userConfig,
Workspace: workspacebuild.Config{
Request: codersdk.CreateWorkspaceRequest{
TemplateID: uuid.Nil,
},
},
},
errContains: "validate workspace",
},
{
name: "BadReconnectingPTYConfig",
config: createworkspaces.Config{
User: userConfig,
Workspace: workspaceConfig,
ReconnectingPTY: &reconnectingpty.Config{
Timeout: httpapi.Duration(-1 * time.Second),
},
},
errContains: "validate reconnecting pty",
},
{
name: "BadAgentConnConfig",
config: createworkspaces.Config{
User: userConfig,
Workspace: workspaceConfig,
AgentConn: &agentconn.Config{
ConnectionMode: "bad",
},
},
errContains: "validate agent conn",
},
}

for _, c := range cases {
c := c

t.Run(c.name, func(t *testing.T) {
t.Parallel()

err := c.config.Validate()
if c.errContains != "" {
require.Error(t, err)
require.Contains(t, err.Error(), c.errContains)
} else {
require.NoError(t, err)
}
})
}
}
14 changes: 14 additions & 0 deletions scaletest/createworkspaces/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,15 @@ import (
"golang.org/x/sync/errgroup"
"golang.org/x/xerrors"

"cdr.dev/slog"
"cdr.dev/slog/sloggers/sloghuman"

"github.com/coder/coder/coderd/tracing"
"github.com/coder/coder/codersdk"
"github.com/coder/coder/cryptorand"
"github.com/coder/coder/scaletest/agentconn"
"github.com/coder/coder/scaletest/harness"
"github.com/coder/coder/scaletest/loadtestutil"
"github.com/coder/coder/scaletest/reconnectingpty"
"github.com/coder/coder/scaletest/workspacebuild"
)
Expand All @@ -37,13 +42,22 @@ func NewRunner(client *codersdk.Client, cfg Config) *Runner {

// Run implements Runnable.
func (r *Runner) Run(ctx context.Context, id string, logs io.Writer) error {
ctx, span := tracing.StartSpan(ctx)
defer span.End()

logs = loadtestutil.NewSyncWriter(logs)
logger := slog.Make(sloghuman.Sink(logs)).Leveled(slog.LevelDebug)
r.client.Logger = logger
r.client.LogBodies = true

_, _ = fmt.Fprintln(logs, "Generating user password...")
password, err := cryptorand.HexString(16)
if err != nil {
return xerrors.Errorf("generate random password for user: %w", err)
}

_, _ = fmt.Fprintln(logs, "Creating user:")
_, _ = fmt.Fprintf(logs, "\tOrg ID: %s\n", r.cfg.User.OrganizationID.String())
_, _ = fmt.Fprintf(logs, "\tUsername: %s\n", r.cfg.User.Username)
_, _ = fmt.Fprintf(logs, "\tEmail: %s\n", r.cfg.User.Email)
_, _ = fmt.Fprintf(logs, "\tPassword: ****************\n")
Expand Down
Loading