Skip to content

fix: markdown-link-check base-branch should not be set on main branch #5311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: markdown-link-check base-branch should not be set on main branch #5311

merged 1 commit into from
Dec 6, 2022

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 6, 2022 •
edited
Loading

Follow-up on: 133b2de

It looks like markdown-link-check can't determine that it's running on the main branch and doesn't scan all files (PR behavior).

@mtojek mtojek self-assigned this Dec 6, 2022
@mtojek mtojek marked this pull request as ready for review December 6, 2022 14:06
@mtojek mtojek requested a review from a team December 6, 2022 14:06
@mtojek mtojek merged commit b2dc60c into coder:main Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @deansheather