Skip to content

fix: UX issues in template settings form's default auto-stop field #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 7, 2022
Merged

fix: UX issues in template settings form's default auto-stop field #5330

merged 8 commits into from
Dec 7, 2022

Conversation

presleyp
Copy link
Contributor

@presleyp presleyp commented Dec 6, 2022

Fixes #5064

  • Uses i18n (I switched to templateSettingsPage for predictability from the component name)
  • Applies helper text when ttl is 0
  • Correctly pluralizes helper text
  • Uses helper text typography using the second arg to getFieldHelpers
  • Uses user-friendly field name in error text

@presleyp presleyp requested a review from a team as a code owner December 6, 2022 21:04
@presleyp presleyp requested review from BrunoQuaresma and removed request for a team December 6, 2022 21:04
BrunoQuaresma
BrunoQuaresma approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@presleyp presleyp merged commit 8ea0923 into main Dec 7, 2022
@presleyp presleyp deleted the auto-stop-setup/presleyp branch December 7, 2022 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: template settings: auto-stop option is confusing
2 participants
@presleyp @BrunoQuaresma