Skip to content

feat: Add diff and Dockerfile support for template version page #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 8, 2022
Merged

feat: Add diff and Dockerfile support for template version page #5339

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7bf286f
Load diff files
BrunoQuaresma Dec 6, 2022
fc414bc
Show diff files with monaco
BrunoQuaresma Dec 6, 2022
b0a0ec0
Update wrapper
BrunoQuaresma Dec 6, 2022
43e256d
Add reference
BrunoQuaresma Dec 6, 2022
294bab5
Add Docker icon
BrunoQuaresma Dec 6, 2022
8503418
Show diff badge
BrunoQuaresma Dec 6, 2022
1c05356
Do safe request
BrunoQuaresma Dec 6, 2022
7585ab1
Improve extension language
BrunoQuaresma Dec 7, 2022
c716995
Merge branch 'main' of github.com:coder/coder into bq/add-diff
BrunoQuaresma Dec 7, 2022
e1bcc93
Add a few fixes
BrunoQuaresma Dec 7, 2022
ed9559f
Add more tests for t previous query
BrunoQuaresma Dec 7, 2022
1db00e3
Update deps
BrunoQuaresma Dec 7, 2022
f86e024
Remove test
BrunoQuaresma Dec 7, 2022
f37dabe
Remove unecessary import
BrunoQuaresma Dec 7, 2022
5c141ba
Fix databse fake
BrunoQuaresma Dec 7, 2022
1ca4d0a
Update coderd/database/queries/templateversions.sql
BrunoQuaresma Dec 8, 2022
9f6dbef
Apply PR suggestions
BrunoQuaresma Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Dec 7, 2022
commit f86e0241a9bc05c6c2a24bb1b5124cd055f6b782
9 changes: 1 addition & 8 deletions site/src/pages/TemplateVersionPage/TemplateVersionPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const TEMPLATE_VERSION_FILES = {
const setup = async () => {
jest
.spyOn(templateVersionUtils, "getTemplateVersionFiles")
.mockResolvedValueOnce(TEMPLATE_VERSION_FILES)
.mockResolvedValue(TEMPLATE_VERSION_FILES)

jest
.spyOn(CreateDayString, "createDayString")
Expand All @@ -40,11 +40,4 @@ describe("TemplateVersionPage", () => {
expect(screen.queryByText(TERRAFORM_FILENAME)).toBeInTheDocument()
expect(screen.queryByText(README_FILENAME)).toBeInTheDocument()
})

it("shows the right content when click on the file name", async () => {
await userEvent.click(screen.getByText(README_FILENAME))
expect(
screen.queryByText(TEMPLATE_VERSION_FILES[README_FILENAME]),
).toBeInTheDocument()
})
})