chore: use goleak.VerifyNone to identify goroutine leak #5346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
I've been able to occasionally reproduce the issue with go test ./coderd/wsconncache -race -timeout=5m -count=40 -parallel 3 on Linux (setting parallel limit isn't required).
But I think this PR is good if if helps us narrow down the culprit!
See also #5348.
Let's revive it if we keep seeing the issue. Thanks for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5302
This PR modifies the
wsconncache_test.goto run tests synchronized (no parallel) to identify the test case which leaks the goroutine.I'm afraid that every test case in
wsconncache_test.gocan be affected, but I don't know why the problem with hanging gvisor routine is caught exactly here.