fix: fmt should check for unstaged files #5362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Dec 9, 2022
mafredri
approved these changes
Dec 9, 2022
| @@ -274,6 +274,9 @@ jobs: | |||
| export PATH=${PATH}:$(go env GOPATH)/bin | |||
| make --output-sync -j -B fmt | |||
|
|
|||
| - name: Check for unstaged files | |||
| run: ./scripts/check_unstaged.sh | |||
There was a problem hiding this comment.
I thinks this is good, should we also consider doing a CI conditional for terraform fmt -check like we do for prettier and shfmt?
There was a problem hiding this comment.
Sorry, I noticed your comment after merging. I can iterate on this if you like, but I assume that check_unstaged.sh as an ultimate check should work here well.
There was a problem hiding this comment.
No worries, I'll leave it up to you. Ultimately this check is great to have as a catch-all, the other is just a minor improvement which doesn't bring much benefit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted in: https://github.com/coder/coder/actions/runs/3643167089/jobs/6151099869
File
dogfood/main.tfhasn't been formatted before, butfmtdoesn't complain about it.