feat: allow http and https listening simultaneously #5365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
commented
Dec 9, 2022
coadler
approved these changes
Dec 14, 2022
coadler
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
--addressin favor of--http-addressand--tls-address.If
--addressis set, prints a warning and then copies it's value to--http-address(or--tls-addressif--tls-enableis true) and clears the other address.New default behavior
Default behavior is to listen on HTTP.
If TLS is enabled, Coder will now listen on a HTTP and a HTTPS port. Users can restore the old behavior by using
--http-address ""to unset the default.TODO:
Closes #3123