chore: Refactor agent tests to avoid t.Run
when not needed
#5376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that writing tests that contain subtests should probably be
limited to table-based tests and tests that share a common setup shared
between tests.
Writing tests with a subtest like this:
Has the following disadvantages:
(unknown)
status whenonly one of the subtests hang (never exit)
t.Setenv
is no longer allowed if the parenttest is parallel
This is from Go 1.20rc1, trying to run the agent tests:
It's unclear if the above is a Go bug or not, but I've (and maybe others) have observed in the past that
t.Setenv
isn't always behaving as expected. This could potentially be the source of that confusing behavior.