Skip to content

feat: support partial parameter files #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2022
Merged

feat: support partial parameter files #5392

merged 2 commits into from
Dec 14, 2022

Conversation

RickyGrassmuck
Copy link
Contributor

@RickyGrassmuck RickyGrassmuck commented Dec 12, 2022 •
edited
Loading

Facilitate consuming partial parameter files and prompt users for any parameters that were expected but not found in the parameter file.

Fixes #5390

@RickyGrassmuck
Support partial parameter files
617a5eb 
Facilitate consuming partial parameter files and prompt users for any parameters
that were expected but not found in the parameter file.
@github-actions
Copy link

github-actions bot commented Dec 12, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@RickyGrassmuck
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@RickyGrassmuck RickyGrassmuck mentioned this pull request Dec 12, 2022
Closed
@RickyGrassmuck
Copy link
Contributor Author

Looks like there are a few places I need to update the tests for. Working through those now.

@RickyGrassmuck
Copy link
Contributor Author

RickyGrassmuck commented Dec 13, 2022 •
edited
Loading

@coadler Was able to get the tests passing locally with the last commit and should pass the CI runs now.

[nix-shell:~/rigrassm-coder]$ make test
exec: [go test -json -v -short ./...]
go test pid: 384701
✓  agent/usershell (5ms)
✓  agent/reaper (20ms)
✓  buildinfo (40ms)
✓  coderd/autobuild/notify (25ms)
✓  coderd/autobuild/schedule (42ms)
✓  cli/config (27ms)
✓  coderd/httpmw/patternmatcher (10ms)
✓  coderd/awsidentity (9ms)
✓  coderd/azureidentity (90ms)
✓  coderd/rbac/regosql/sqltypes (10ms)
✓  coderd/util/ptr (8ms)
✓  coderd/database/migrations (34ms)
✓  coderd/database/postgres (10ms)
✓  coderd/util/tz (45ms)
✓  coderd/util/slice (16ms)
✓  coderd/userpassword (377ms)
✓  cryptorand (65ms)
✓  coderd/rbac/regosql (23ms)
✓  provisioner (9ms)
✓  coderd/tracing (36ms)
✓  pty (29ms)
✓  provisioner/echo (26ms)
✓  coderd/gitsshkey (1.722s)
✓  provisionersdk (187ms)
✓  testutil (107ms)
✓  scripts/apitypings (279ms)
✓  pty/ptytest (12ms)
✓  coderd/database/databasefake (56ms)
✓  coderd/database (22ms)
✓  provisionerd (2.183s)
✓  coderd/parameter (49ms)
✓  coderd/telemetry (78ms)
✓  coderd/updatecheck (132ms)
✓  cli/cliflag (27ms)
✓  coderd/rbac (5.852s)
✓  coderd/gitauth (57ms)
✓  cli/deployment (40ms)
✓  coderd/httpapi (48ms)
✓  enterprise/tailnet (64ms)
✓  coderd/devtunnel (1.134s)
✓  enterprise/replicasync (763ms)
✓  coderd/provisionerdserver (72ms)
✓  enterprise/audit (39ms)
✓  cli/cliui (614ms)
✓  enterprise/derpmesh (1.698s)
✓  coderd/metricscache (2.533s)
✓  enterprise/audit/backends (40ms)
✓  coderd/wsconncache (1.823s)
✓  codersdk (659ms)
✓  coderd/prometheusmetrics (201ms)
✓  examples (99ms)
✓  loadtest/placebo (24ms)
✓  coderd/httpmw (5.089s)
✓  enterprise/trialer (158ms)
✓  enterprise/coderd/license (206ms)
✓  tailnet (214ms)
✓  tailnet/tailnettest (56ms)
✓  loadtest/harness (3.852s)
✓  coderd/coderdtest (1.878s)
✓  cli/clitest (202ms)
✓  loadtest/reconnectingpty (183ms)
✓  coderd/autobuild/executor (3.338s)
✓  site (49ms)
✓  enterprise/coderd/coderdenttest (1.222s)
✓  enterprise/cli (321ms)
✓  loadtest/workspacebuild (159ms)
✓  agent (11.464s)
✓  enterprise/coderd (6.142s)
✓  cli (11.323s)
∅  cmd/cliui
∅  cmd/coder
✓  coderd (14.969s)
∅  coderd/audit
∅  coderd/database/dbtestutil
∅  coderd/database/dbtype
∅  coderd/database/gen/dump
∅  coderd/database/gen/enum
∅  enterprise/audit/audittest
∅  enterprise/cmd/coder
✓  loadtest/agentconn (18.458s)
∅  loadtest/loadtestutil
✓  provisioner/terraform (30.314s)
∅  provisionerd/proto
∅  provisionerd/runner
∅  provisionersdk/proto
∅  scripts
∅  scripts/auditgen
∅  scripts/metricsdocgen
∅  scripts/migrate-ci

...

DONE 2513 tests, 19 skipped in 50.320s

coadler
coadler approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@coadler coadler changed the title Support partial parameter files feat: support partial parameter files Dec 14, 2022
@coadler coadler merged commit f7baf45 into coder:main Dec 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Allow partially filled out parameter files
2 participants
@RickyGrassmuck @coadler