Skip to content

fix: stop time incrementer on workspace page #5406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 21, 2022
Merged

fix: stop time incrementer on workspace page #5406

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
42de7e5
Check template default ttl while setting max
presleyp Dec 13, 2022
5e8f6d6
Lint
presleyp Dec 13, 2022
7c8d7fb
Remove template default from max ttl consideration
presleyp Dec 15, 2022
4634118
Finish removing template
presleyp Dec 15, 2022
35a77fb
Fix disabling buttons
presleyp Dec 16, 2022
56c2a79
Simplify, wip
presleyp Dec 20, 2022
e1088ff
Handle NaN
presleyp Dec 20, 2022
359653a
Format
presleyp Dec 20, 2022
7743fa0
Add aria labels
presleyp Dec 20, 2022
0ddf307
Explain NaN handling
presleyp Dec 20, 2022
39ec159
Use more realistic storybook args
presleyp Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explain NaN handling
  • Loading branch information
@presleyp
presleyp committed Dec 20, 2022
commit 0ddf307d617952423e21393fb3110028e68ebdf0
1 change: 1 addition & 0 deletions site/src/components/WorkspaceScheduleButton/EditHours.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const EditHours = ({
const styles = useStyles()

return (
// hours is NaN when user deletes the value, so treat it as 0
<form onSubmit={() => handleSubmit(Number.isNaN(hours) ? 0 : hours)}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is it going to be NaN?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you delete the number from the input

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a comment explaining this? So we know why we are checking it. Up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

<Stack direction="row" alignItems="baseline" spacing={1}>
<TextField
Expand Down