Skip to content

fix: No org admins until organizations are in the UI #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Dec 14, 2022

Fixes #5379

Until organizations have management UI, we should not set any org admins. This goes around the site wide perms transparently and is confusing to users.

Migration

I made the migration put all org members to only members. Removing all admins.

Until organizations have management UI, we should not set any org
admins. This goes around the site wide perms transparently and
is confusing to users.
Default user is no longer an org admin, so the demotion test makes
no sense
@Emyrk Emyrk requested review from mafredri and johnstcn December 14, 2022 15:54
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@Emyrk Emyrk merged commit 27386d4 into main Dec 14, 2022
@Emyrk Emyrk deleted the stevenmasley/no_org_admins branch December 14, 2022 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
@ghuntley ghuntley added the security Area: security label Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security Area: security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: A user with a member role can execute, and even delete other members' workspaces.
4 participants