Skip to content

fix: Avoid deadlock in AgentReportStats Close during agent Close #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change logger error to debug
  • Loading branch information
mafredri committed Dec 14, 2022
commit 82ee502e95188b82c76e38c7adbd0a900bddaa1d
2 changes: 1 addition & 1 deletion agent/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (a *agent) run(ctx context.Context) error {
<-a.closed
_ = cl.Close()
}); err != nil {
a.logger.Error(ctx, "report stats goroutine", slog.Error(err))
a.logger.Debug(ctx, "report stats goroutine", slog.Error(err))
_ = cl.Close()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Is stats reporter startup failure fatal? I.e. do we return an error or not?

}
}
Expand Down