Skip to content

fix: improve the warning mismatch to display the release assets on windows #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2022
Merged

fix: improve the warning mismatch to display the release assets on windows #5418

merged 3 commits into from
Dec 14, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #4226.

@kylecarbs kylecarbs requested a review from mafredri December 14, 2022 16:07
@kylecarbs kylecarbs self-assigned this Dec 14, 2022
mafredri
mafredri approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If check fix, otherwise LGTM!

kylecarbs and others added 2 commits December 14, 2022 10:11
@kylecarbs @mafredri
Update cli/root.go
56992c6 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@kylecarbs @mafredri
Update cli/root.go
3165f39 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@kylecarbs kylecarbs enabled auto-merge (squash) December 14, 2022 16:11
@kylecarbs kylecarbs merged commit 8e702d8 into main Dec 14, 2022
@kylecarbs kylecarbs deleted the winwarn branch December 14, 2022 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: do not show install script on Windows client
2 participants
@kylecarbs @mafredri