ci: Improve gotestsum failure detection, prevent early exit #5420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d8ea2f to
bce52ce
Compare
591c69e to
d0a3e50
Compare
mafredri
commented
Dec 14, 2022
| ret=$? | ||
| if ((ret)); then | ||
| # Eternalize test timeout logs because "re-run failed" erases | ||
| # artifacts and gotestsum doesn't always capture it: | ||
| # https://github.com/gotestyourself/gotestsum/issues/292 | ||
| echo "Checking gotestsum.json for panic trace:" | ||
| grep -A 999999 'panic: test timed out' gotestsum.json |
There was a problem hiding this comment.
Review: This was pretty loud (so many logs after timeout), so I decided to only capture the stack trace, and while I was at it, only when the criteria is met.
mafredri
commented
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes early exit (missing
set +e) which prevented theifstatement from being executed.Since the log was too noisy, I applied filtering and edge case detection.
Example output after this PR: https://github.com/coder/coder/actions/runs/3697831254/jobs/6273476923
PS. I never realized, but it seems setting
-timeout=Xmlike we do applies on a per-package basis, not the entire run ofgo test. As a result, the entire run can be much longer it seems 🤔 (or am I misunderstanding something?)