feat: add external property to coder_app
#5425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows exposing applications that open an external URL.
99f4d65 to
33db70d
Compare
jsjoeio
approved these changes
Dec 14, 2022
33db70d to
1577aaa
Compare
coadler
approved these changes
Dec 14, 2022
1577aaa to
6e14fc6
Compare
Coder admins have expressed interest in adding links to external resources as "shortcuts" within the workspaces. For example, a link to a setup wiki, google cloud project, etc. As a user, this could make onboarding and troubleshooting quite straightforward:
Use the guide + code-server to start coding on the specific project :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
coder_appto expose external links, like google.com!Also contributes towards #4551. While not solving the issue entirely, there was a bug with health checks where if a single app didn't have a health check, it would fail to report.