test: Fix scaletest/reconnectingpty
commands for use in powershell
#5439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm confused as to why this works in CI, the default shell must be bash. In my Windows VM, I'm unable to successfully run the tests because powershell is spawned.
This fix only fixes powershell,
cmd.exe
won't sleep it'll just echo the line including; sleep 1
. Forcmd.exe
the&&
works, but needs to usetimeout 1
instead.Perhaps we should explicitly invoke a shell, depending on platform, to control the parsing/execution?