feat: Manage tokens in dashboard #5444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
4587f70 to
4500b71
Compare
d3321f4 to
01be801
Compare
presleyp
reviewed
Jan 12, 2023
| {tokens?.map((token) => { | ||
| const t = dayjs(token.last_used) | ||
| const now = dayjs() | ||
| const lastUsed = now.isBefore(t.add(100, "year")) |
There was a problem hiding this comment.
I guess this is needed because last_used can't be set to null? Might be nice to put this in a util function with a little comment.
presleyp
reviewed
Jan 12, 2023
| expiresAtLabel: "Expires At", | ||
| emptyMessage: "No tokens found", | ||
| ariaDeleteLabel: "Delete Token", | ||
| } |
There was a problem hiding this comment.
We have an alternative to Language now, react-i18n, but if it's a hassle, don't worry about it, we're going to revisit whether it's worth the time
presleyp
approved these changes
Jan 12, 2023
01be801 to
24e3f99
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.