Skip to content

fix: fix nested dirs in example tars #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2022
Merged

fix: fix nested dirs in example tars #5447

merged 2 commits into from
Dec 16, 2022

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Dec 16, 2022 •
edited
Loading

The example tar generation code had some problems compared to the regular directory -> tar code we use for provisioners:

  1. it included ./ prefix on every file
  2. it included the root entry ./ when it's not supposed to
  3. directories had the mode 0644 when it should've been 0755
  4. subdirectory contents weren't added properly

This caused the docker template to not work using the example_id field on template version creation.

@deansheather deansheather requested a review from f0ssel December 16, 2022 15:58
@deansheather deansheather merged commit 0c0e3f0 into main Dec 16, 2022
@deansheather deansheather deleted the dean/fix-example-tars branch December 16, 2022 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@f0ssel f0ssel Awaiting requested review from f0ssel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @kylecarbs