test: Unit tests creating fake audit logs require create permission #5455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Dec 19, 2022
| @@ -79,7 +79,7 @@ func (api *API) auditLogs(rw http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| func (api *API) generateFakeAuditLog(rw http.ResponseWriter, r *http.Request) { | |||
| ctx := r.Context() | |||
| if !api.Authorize(r, rbac.ActionRead, rbac.ResourceAuditLog) { | |||
| if !api.Authorize(r, rbac.ActionCreate, rbac.ResourceAuditLog) { | |||
There was a problem hiding this comment.
I might have missed it, but I don't see us enforcing this authorization in production. Is it sensible here? I imagine auditing shouldn't be user-permission dependent?
There was a problem hiding this comment.
If this is only used in unit tests then it probably doesn't matter. I was just fixing the auth check to match the actual action
There was a problem hiding this comment.
@mafredri I see this route as a valid route being usable even in production. If it should be test scoped, that should be done in another PR. At the very least, this authz should be checked since an audit log is inserted.
mafredri
approved these changes
Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.