Skip to content

build: Improve speed of find commands in Makefile #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

mafredri
Copy link
Member

Using -not -path simply removes the path from the output, using -prune eliminates the search path thus preventing us from traversing everything insidie e.g. node_modules.

@mafredri mafredri self-assigned this Dec 19, 2022
@mafredri mafredri requested review from a team and kylecarbs and removed request for a team December 19, 2022 12:27
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@mafredri mafredri force-pushed the mafredri/build-makefile-find-improvement branch from 7b91a79 to 28e6c7e Compare December 19, 2022 12:32
@mafredri mafredri merged commit 9983c07 into main Dec 19, 2022
@mafredri mafredri deleted the mafredri/build-makefile-find-improvement branch December 19, 2022 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants